Fix invalid escape sequence warning #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Python starts warning in 3.6+ about invalid escape sequences in strings. These regexes currently trigger that warning, but we can fix that easily by converting them to raw strings instead. Test Plan: For each string changed, tested that '$str' == r'$str' in the python shell. ran tox and confirmed it still passed for py37, py38, py39 and py310
Codecov Report
@@ Coverage Diff @@
## main #93 +/- ##
=======================================
Coverage 77.92% 77.92%
=======================================
Files 2 2
Lines 231 231
=======================================
Hits 180 180
Misses 51 51
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This looks great, thanks for the fix! |
|
Thanks for taking a look so fast! |
|
By the way, would you be open to releasing a new minor version of titlecase on PyPI with this patch? Definitely not urgent, but it would be nice to be able to use the version of this library without this warning showing up. |
ppannuto
added a commit
that referenced
this pull request
Sep 23, 2023
- #93: Fix invalid escape sequence warning; thanks @benhiller!
|
You have remarkably good timing in when you happen to ask for things... pushed :) |
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Python starts warning in 3.6+ about invalid escape sequences in strings. These regexes currently trigger that warning, but we can fix that easily by converting them to raw strings instead.
Test Plan: For each string changed, tested that '$str' == r'$str' in the python shell. ran tox and confirmed it still passed for py37, py38, py39 and py310